Ui for Plan #72
Merged
Ui for Plan #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 173
💛 - Coveralls |
tiuweehan
approved these changes
Oct 15, 2019
| * As a consequence, UI elements' variable names cannot be set to such keywords | ||
| * or an exception will be thrown by JavaFX during runtime. | ||
| * | ||
| * @see <a href="https://github.com/se-edu/addressbook-level4/issues/336">The issue on AddressBook level 4</a> |
There was a problem hiding this comment.
I realize this comment can be removed
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| // short circuit if same object |
There was a problem hiding this comment.
Try to avoid using comments that describe 'how'. They should be used for describing 'why'
| endDate.setText(plan.getEndDate().format(Plan.FORMATTER)); | ||
| plan.getTasks().stream() | ||
| .sorted(Comparator.comparing(Task::getDateTime)) | ||
| .forEach(task -> tasks.getChildren().add(new Label(task.getProblem().toString() + '\n' |
There was a problem hiding this comment.
Could abstract this out into a formatter
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.