Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Relational Storage for Models #80

Merged
merged 10 commits into from Oct 22, 2019
Merged

Implement Relational Storage for Models #80

merged 10 commits into from Oct 22, 2019

Conversation

jiayushe
Copy link

@jiayushe jiayushe commented Oct 16, 2019 •
edited

@jiayushe jiayushe added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 16, 2019
@jiayushe jiayushe added this to the v1.3 milestone Oct 16, 2019
@jiayushe jiayushe added this to In progress in AlgoBase via automation Oct 16, 2019
@coveralls
Copy link

coveralls commented Oct 16, 2019 •
edited

Pull Request Test Coverage Report for Build 236

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 409 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-1.8%) to 32.93%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/AddPlanCommandParser.java 3 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/EditTagCommand.java 4 6.45%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/plan/PlanDescription.java 6 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/PlanCard.java 8 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/TaskCard.java 9 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/tag/Tag.java 11 47.83%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/DeleteTaskCommand.java 13 3.7%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/DoneTaskCommand.java 13 3.57%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/UndoneTaskCommand.java 13 3.57%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/storage/JsonSerializableAlgoBase.java 14 25.81%
Totals Coverage Status
Change from base Build 232: -1.8%
Covered Lines: 980
Relevant Lines: 2976
💛 - Coveralls

@jiayushe jiayushe force-pushed the add-tasks branch 3 times, most recently from c5af456 to f5c8479 Compare October 21, 2019 15:59
@jiayushe jiayushe requested a review from le0tan October 21, 2019 16:01
@jiayushe jiayushe marked this pull request as ready for review October 21, 2019 16:01
@jiayushe jiayushe self-assigned this Oct 21, 2019
@jiayushe jiayushe added status.reviewRequired and removed status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. labels Oct 21, 2019
le0tan
le0tan requested changes Oct 22, 2019
View reviewed changes
src/main/java/seedu/algobase/logic/commands/DeleteTaskCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/DeleteTaskCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/DoneTaskCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/EditCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/EditPlanCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/UndoneTaskCommand.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/parser/CliSyntax.java Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/logic/parser/CliSyntax.java Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/model/problem/Problem.java Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/model/task/Task.java Outdated Show resolved Hide resolved
AlgoBase automation moved this from In progress to Review in progress Oct 22, 2019
@jiayushe jiayushe requested a review from le0tan October 22, 2019 13:33
le0tan
le0tan approved these changes Oct 22, 2019
View reviewed changes
Copy link

@le0tan le0tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider abstracting the generation and storage of Id in the next PR plz.

src/main/java/seedu/algobase/logic/parser/CliSyntax.java Show resolved Hide resolved
AlgoBase automation moved this from Review in progress to Reviewer approved Oct 22, 2019
@jiayushe jiayushe force-pushed the add-tasks branch 3 times, most recently from 6cdbf7c to b1e383b Compare October 22, 2019 15:43
@jiayushe jiayushe merged commit 7968f1e into AY1920S1-CS2103T-W11-1:master Oct 22, 2019
AlgoBase automation moved this from Reviewer approved to Done Oct 22, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 22, 2019
Closed
23 tasks
@jiayushe jiayushe changed the title Update Task Feature Implement Relational Storage for Models Oct 29, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 29, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiuweehan tiuweehan tiuweehan left review comments

@le0tan le0tan le0tan approved these changes

Assignees

@jiayushe jiayushe

Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.3
4 participants
@jiayushe @coveralls @le0tan @tiuweehan