Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement search feature for help command #81

Merged
merged 7 commits into from Oct 18, 2019
Merged

Implement search feature for help command #81

merged 7 commits into from Oct 18, 2019

Conversation

le0tan
Copy link

@le0tan le0tan commented Oct 17, 2019

Closes #69
Please take a good look at HelpCommandTest.java. Thanks!

@le0tan le0tan added this to the v1.3 milestone Oct 17, 2019
@le0tan le0tan requested a review from jiayushe October 17, 2019 07:18
@le0tan le0tan added this to In progress in AlgoBase via automation Oct 17, 2019
@coveralls
Copy link

coveralls commented Oct 17, 2019 •
edited

Pull Request Test Coverage Report for Build 186

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.3%) to 35.915%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/CommandResult.java 1 66.67%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/HelpCommand.java 2 91.67%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/commons/util/AppUtil.java 4 66.67%
Totals Coverage Status
Change from base Build 179: 1.3%
Covered Lines: 946
Relevant Lines: 2634
💛 - Coveralls

AlgoBase automation moved this from In progress to Review in progress Oct 17, 2019
@le0tan le0tan requested a review from jiayushe October 18, 2019 04:32
jiayushe
jiayushe approved these changes Oct 18, 2019
View reviewed changes
Copy link

@jiayushe jiayushe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlgoBase automation moved this from Review in progress to Reviewer approved Oct 18, 2019
@le0tan le0tan merged commit 0ef1961 into AY1920S1-CS2103T-W11-1:master Oct 18, 2019
AlgoBase automation moved this from Reviewer approved to Done Oct 18, 2019
@le0tan le0tan self-assigned this Oct 22, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 22, 2019
Closed
23 tasks
@le0tan le0tan deleted the help branch October 23, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayushe jiayushe jiayushe approved these changes

Assignees

@le0tan le0tan

Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a user, I want to see all available commands and command formats using help
3 participants
@le0tan @coveralls @jiayushe