Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debt simplification algorithm #101

Merged
merged 12 commits into from Oct 22, 2019
Merged

Debt simplification algorithm #101

merged 12 commits into from Oct 22, 2019

Conversation

podocarp
Copy link
Member

@podocarp podocarp commented Oct 18, 2019 •
edited

Please try it out!
Reference #70

@podocarp podocarp requested a review from a team October 18, 2019 16:23
@podocarp podocarp self-assigned this Oct 18, 2019
@podocarp podocarp added the priority.High Must do label Oct 18, 2019
@podocarp podocarp added this to the v1.3 milestone Oct 18, 2019
@podocarp podocarp requested a review from a team October 19, 2019 04:41
@podocarp podocarp mentioned this pull request Oct 19, 2019
Closed
Aulud
Aulud previously approved these changes Oct 21, 2019
View reviewed changes
Copy link

@Aulud Aulud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay overall - light testing doesn't reveal any unintended behaviour so far.

src/main/java/seedu/address/model/activity/Activity.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/activity/Activity.java Show resolved Hide resolved
src/main/java/seedu/address/model/activity/Activity.java Show resolved Hide resolved
This was referenced Oct 22, 2019
Merged
Closed
Closed
@podocarp
Copy link
Member Author

podocarp commented Oct 22, 2019 •
edited

Recommended to check out #110 after this to minimize conflicts later on, but just a suggestion.

daekoon
daekoon approved these changes Oct 22, 2019
View reviewed changes
Copy link

@daekoon daekoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daekoon daekoon merged commit cdae484 into master Oct 22, 2019
@daekoon daekoon deleted the algorithmic branch October 22, 2019 03:37
@nus-se-bot nus-se-bot mentioned this pull request Oct 22, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daekoon daekoon daekoon approved these changes

@Aulud Aulud Aulud left review comments

Assignees

@podocarp podocarp

Labels
priority.High Must do
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@podocarp @daekoon @Aulud