Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation details of List command to DG #116

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Add implementation details of List command to DG #116

merged 4 commits into from
Oct 23, 2019

Conversation

Aulud
Copy link

@Aulud Aulud commented Oct 22, 2019

Add implementation details of List command to DG

Summary: Documents the extended List command from PR #112. Required for Week 10's tutorial.

Changelog

  • Add full sequence diagram for the List command (involves components from Ui, Logic and Model groups)
  • Add implementation details of the List command, including the Context class, along with a sample usage

@Aulud Aulud added the documentation Improvements or additions to documentation label Oct 22, 2019
@Aulud Aulud added this to the v1.3 milestone Oct 22, 2019
@Aulud Aulud requested a review from a team October 22, 2019 21:50
JohnNzj
JohnNzj approved these changes Oct 23, 2019
View reviewed changes
Copy link

@JohnNzj JohnNzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohnNzj JohnNzj merged commit 0add222 into master Oct 23, 2019
@JohnNzj JohnNzj deleted the add-list-command-dev-guide branch October 23, 2019 04:00
@nus-se-bot nus-se-bot mentioned this pull request Oct 29, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNzj JohnNzj JohnNzj approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aulud @JohnNzj