Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Activity list not updating when participants of an Activity changes #143

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Fix Activity list not updating when participants of an Activity changes #143

merged 3 commits into from
Nov 1, 2019

Conversation

Aulud
Copy link

@Aulud Aulud commented Oct 31, 2019

Fix Activity list not updating when participants of an Activity changes

Bug description: When in the VIEW_ACTIVITY context, inviting or disinviting participants fails to prompt the list of activities (shown in LIST_ACTIVITY context) to re-render the respective cell, since the Activity instance is mutable and its properties are not wrapped with the Observable<T> JavaFX class.

Changelog

  • Fix the ListView of Activity cells in ActivityListPanel not re-rendering when a user changes the participants of one or more activities with the Invite or Disinvite command
    • Switching to a LIST_ACTIVITY context now unconditionally forces a refresh of the view rendered by the ListView in ActivityListPanel

@Aulud Aulud added the severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. label Oct 31, 2019
@Aulud Aulud added this to the v1.4 milestone Oct 31, 2019
@Aulud Aulud requested review from liakify and a team and removed request for liakify October 31, 2019 18:36
daekoon
daekoon approved these changes Oct 31, 2019
View reviewed changes
Copy link

@daekoon daekoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aulud Aulud merged commit 7297e05 into master Nov 1, 2019
@Aulud Aulud deleted the fix-static-activity-list-view branch November 1, 2019 01:27
@nus-se-bot nus-se-bot mentioned this pull request Nov 5, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daekoon daekoon daekoon approved these changes

Assignees
No one assigned
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aulud @daekoon