Add bugfixes and minor features to View command UI

[Aulud]

Add bugfixes and minor features to View command UI

Summary: Fixes a few critical issues with the View command UI and introduces several minor features to improve UX. Verified to work (without severe bugs) on both Windows 10 and Ubuntu 16.04 LTS operating systems.

Changelog

• Fix total activity spending including the amount from deleted expenses and settlements
• Fix soft-deleted expenses not appearing visually different from other expenses
  • Soft-deleted expenses and settlements will now have all their text and participant tags greyed out
• Display the index of each expense in an activity in its description
• Add CSS styling to visually distinguish settlements from expenses, even when soft-deleted
• Contract amounts less than $0.01 to <$0.01 when displayed in PersonDetailsPanel, ExpenseCard and TransferCard
• Display the placeholder message no email provided in place of a contact's email when viewing a contact with no specified email
• Refactor JavaFX UI classes
  • Add AssertionError detail messages to existing Java assertions
  • Correct unnecessary public access modifier for instance attributes
  • Extract business logic from ActivityCard and ActivityDetailsPanel, replacing them with utility methods exposed by the Activity class
  • Extract common utility methods for string formatting into the utility class UiUtil
  • Collate all conditional (dynamic) CSS styling rules into Extensions.css
• Fix incorrect format specifier in MESSAGE_SUCCESS of SettleCommand
• Fix mistakes in the getSolution method exposed by the Activity class

Last updated 11 Nov 2019, 01:30AM

[daekoon]

LGTM