Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status bar to show active context; remove debug ID display #206

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

Aulud
Copy link

@Aulud Aulud commented Nov 10, 2019

Improve status bar to show active context; remove debug ID display

Summary: Addresses the small feature request #133 to make the status bar more useful, and additionally addresses #189.

Note to fellow developers

Please only merge in this PR when we are absolutely certain that the ID labels are no longer needed for debug purposes. Thanks!

Changelog

  • Amend the status bar footer to describe the active context; addresses Change status bar to show context #133
    • Exception is during the initial app startup, where the status bar will instead display the file path to addressbook.json
  • Remove all debug ID labels from ActivityCard and PersonCard

Last updated 11 Nov 2019, 02:15AM

@Aulud Aulud added type.Enhancement New feature or request type.Task Something that needs to be done, but not a story, bug, or an epic. labels Nov 10, 2019
@Aulud Aulud added this to the v1.4 milestone Nov 10, 2019
@Aulud Aulud requested a review from a team November 10, 2019 18:24
Copy link

@daekoon daekoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement New feature or request type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants