Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amount class and JsonAdaptedExpense class #72

Merged
merged 13 commits into from Oct 11, 2019
Merged

Conversation

liakify
Copy link

@liakify liakify commented Oct 9, 2019

Changelog

  • Add Amount class to do self validation (expense amount must be a positive number)
  • Add JsonAdaptedExpense class to support JSON serialisation of Expense
  • Modified Expense class to use Amount class instead
  • Add unit tests for Amount, Expense and JsonAdaptedExpense

Copy link
Member

@podocarp podocarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, seems good otherwise

@liakify liakify requested a review from podocarp October 10, 2019 13:36
Copy link

@Aulud Aulud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants