Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Context class and update Model to require context #90

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Add Context class and update Model to require context #90

merged 4 commits into from
Oct 16, 2019

Conversation

liakify
Copy link

@liakify liakify commented Oct 15, 2019 •
edited

Changelog:

  • Added a class Context to represent a context
  • Modified Model and ModelManager to store a context
  • Update Model equals method to check for activityBook equality as well

Aulud
Aulud reviewed Oct 15, 2019
View reviewed changes
Copy link

@Aulud Aulud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the groundwork for contextual commands! 😃 Just some minor questions on some oddities.

src/main/java/seedu/address/model/ModelManager.java Show resolved Hide resolved
src/main/java/seedu/address/model/Context.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Outdated Show resolved Hide resolved
@nus-se-bot nus-se-bot mentioned this pull request Oct 16, 2019
Closed
25 tasks
@liakify liakify requested review from daekoon, JohnNzj, podocarp and a team and removed request for podocarp, daekoon and JohnNzj October 16, 2019 04:29
daekoon
daekoon approved these changes Oct 16, 2019
View reviewed changes
Copy link

@daekoon daekoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liakify liakify changed the title Add Context enum and update Model to require context Add Context class and update Model to require context Oct 16, 2019
@JohnNzj JohnNzj merged commit e541f09 into master Oct 16, 2019
@JohnNzj JohnNzj deleted the add-model-context branch October 16, 2019 11:31
@liakify liakify mentioned this pull request Oct 16, 2019
Closed
@nus-se-bot nus-se-bot mentioned this pull request Oct 22, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daekoon daekoon daekoon approved these changes

@Aulud Aulud Aulud left review comments

@JohnNzj JohnNzj JohnNzj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liakify @daekoon @Aulud @JohnNzj