Implement 3-column UI #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Shift content block to center column - Add placeholder right column for news feed - Refactor basic styles
jakq
approved these changes
Oct 15, 2019
Comment on lines
-72
to
-105
| private void setAccelerators() { | ||
| setAccelerator(helpMenuItem, KeyCombination.valueOf("F1")); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the accelerator of a MenuItem. | ||
| * @param keyCombination the KeyCombination value of the accelerator | ||
| */ | ||
| private void setAccelerator(MenuItem menuItem, KeyCombination keyCombination) { | ||
| menuItem.setAccelerator(keyCombination); | ||
|
|
||
| /* | ||
| * TODO: the code below can be removed once the bug reported here | ||
| * https://bugs.openjdk.java.net/browse/JDK-8131666 | ||
| * is fixed in later version of SDK. | ||
| * | ||
| * According to the bug report, TextInputControl (TextField, TextArea) will | ||
| * consume function-key events. Because CommandBox contains a TextField, and | ||
| * ResultDisplay contains a TextArea, thus some accelerators (e.g F1) will | ||
| * not work when the focus is in them because the key event is consumed by | ||
| * the TextInputControl(s). | ||
| * | ||
| * For now, we add following event filter to capture such key events and open | ||
| * help window purposely so to support accelerators even when focus is | ||
| * in CommandBox or ResultDisplay. | ||
| */ | ||
| getRoot().addEventFilter(KeyEvent.KEY_PRESSED, event -> { | ||
| if (event.getTarget() instanceof TextInputControl && keyCombination.match(event)) { | ||
| menuItem.getOnAction().handle(new ActionEvent()); | ||
| event.consume(); | ||
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Good that you removed code that was deemed unnecessary, especially the menubar which is not part of our product UI
Comment on lines
+1
to
+50
| // General UI | ||
| .root, .list-cell { | ||
| -fx-background-color: white; | ||
| } | ||
| .list-cell:selected { | ||
| -fx-background-color: #eee; | ||
| } | ||
|
|
||
| .list-cell Label, | ||
| .list-cell:selected Label { | ||
| -fx-text-fill: black; | ||
| } | ||
|
|
||
| // Utilities | ||
| .container { | ||
| -fx-padding: 10; | ||
| } | ||
|
|
||
| .plain-border-box { | ||
| -fx-border-color: #ccc; | ||
| -fx-border-radius: 0; | ||
| -fx-border-insets: 0; | ||
| -fx-background-color: white; | ||
| -fx-background-radius: 0; | ||
| -fx-background-insets: 0; | ||
| } | ||
|
|
||
| // Person card | ||
| .list-item { | ||
| -fx-padding: 10 0; | ||
| -fx-border-width: 0 0 1 0; | ||
| -fx-border-color: #ccc; | ||
| } | ||
|
|
||
| #tags { | ||
| -fx-padding: 5 0 0 0; | ||
| -fx-hgap: 5; | ||
| -fx-vgap: 5; | ||
| } | ||
|
|
||
| #tags Label { | ||
| -fx-text-fill: white; | ||
| -fx-padding: 5; | ||
| -fx-background-color: orange; | ||
| } | ||
|
|
||
| // Statusbar | ||
| .statusbar { | ||
| -fx-padding: 0 10 10; | ||
| } |
There was a problem hiding this comment.
Nice that you came up with a theme for the app instead of the same AB3 theme.
Comment on lines
+9
to
+11
| <Label fx:id="name" text="\$first" wrapText="true"/> | ||
| <Label fx:id="address" text="\$address" wrapText="true"/> | ||
| <Label fx:id="category" text="\$category" wrapText="true"/> |
|
Overall, sick edits to the UI!! Really like the plain white minimalistic view, like the apple fan you are :') |
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48