Update developer guide with Mode command details #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakq
requested changes
Oct 23, 2019
| image::ModeCommandSequenceDiagram.png[] | ||
|
|
||
| The following activity diagram summarizes what happens when a user executes a new command: | ||
| image::ModeCommandActivity.png[] |
There was a problem hiding this comment.
good that you used different diagrams to aid in the visualisation
docs/DeveloperGuide.adoc
Outdated
| ** Cons: More effort required for maintenance purposes. Need to make sure that data from main list should not go into todo list, and vice versa | ||
|
|
||
| //end::modeCommand[] | ||
|
|
||
| // tag::dataencryption[] | ||
| === [Proposed] Data Encryption | ||
|
|
There was a problem hiding this comment.
same as rohit, need to fetch upstream master again because the bottom part messed up. The current master should have the correct appendix
jakq
approved these changes
Oct 23, 2019
jakq
pushed a commit
that referenced
this pull request
Oct 23, 2019
* remove email field * Remove email field * Remove phone field * Remove phone attribute * Remove phone, email from test case * Resolve merge conflicts * Add details of review command to Developer Guide * Dg (#5) * Rework CloseCommand class (#79) * Refactor Person to Eatery v1.0 with 3 EditCommandTest failures. * Removed 2 test cases from EditCommandTest * Update BetterModelClassDiagram.puml * Remove Email and Phone class * Remove Email Phone multiplicity * Refactor Person to Eatery edit1 * Add Close Command * Restore whiteline to AddressBookTest * Merge remote-tracking branch 'upstream/master' into close-open-eatery # Conflicts: # src/main/java/seedu/address/logic/Logic.java # src/main/java/seedu/address/logic/LogicManager.java # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/ParserUtil.java # src/main/java/seedu/address/model/AddressBook.java # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/ModelManager.java # src/main/java/seedu/address/model/eatery/Eatery.java # src/main/java/seedu/address/model/eatery/UniqueEateryList.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/JsonAdaptedEatery.java # src/main/java/seedu/address/storage/JsonSerializableAddressBook.java # src/main/java/seedu/address/ui/EateryCard.java # src/main/java/seedu/address/ui/MainWindow.java # src/main/resources/view/EateryListCard.fxml # src/main/resources/view/EateryListPanel.fxml # src/main/resources/view/MainWindow.fxml # src/test/data/JsonSerializableAddressBookTest/duplicateEateryAddressBook.json # src/test/data/JsonSerializableAddressBookTest/invalidEateryAddressBook.json # src/test/data/JsonSerializableAddressBookTest/typicalEateriesAddressBook.json # src/test/java/seedu/address/logic/LogicManagerTest.java # src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java # src/test/java/seedu/address/logic/commands/AddCommandTest.java # src/test/java/seedu/address/logic/commands/ClearCommandTest.java # src/test/java/seedu/address/logic/commands/DeleteCommandTest.java # src/test/java/seedu/address/logic/commands/EditCommandTest.java # src/test/java/seedu/address/logic/commands/FindCommandTest.java # src/test/java/seedu/address/logic/commands/ListCommandTest.java # src/test/java/seedu/address/logic/parser/AddCommandParserTest.java # src/test/java/seedu/address/logic/parser/AddressBookParserTest.java # src/test/java/seedu/address/logic/parser/EditCommandParserTest.java # src/test/java/seedu/address/logic/parser/ParserUtilTest.java # src/test/java/seedu/address/model/AddressBookTest.java # src/test/java/seedu/address/model/ModelManagerTest.java # src/test/java/seedu/address/model/eatery/EateryTest.java # src/test/java/seedu/address/model/eatery/UniqueEateryListTest.java # src/test/java/seedu/address/storage/JsonAdaptedEateryTest.java # src/test/java/seedu/address/testutil/EateryBuilder.java # src/test/java/seedu/address/testutil/EateryUtil.java # src/test/java/seedu/address/testutil/EditEateryDescriptorBuilder.java # src/test/java/seedu/address/testutil/TypicalEateries.java * Fix CloseCommand 1. Remove buildClose() from EateryBuilder 2. Add EOF line to EateryListPanel.fxml 3. Fix duplicateEateryAddressBook.json 4. Require nonnull Category for Eatery * Remove tags from requireAllNonNull in Eatery * Rework execute method of CloseCommand - Removed the hasExactEatery method and its calls. * Merge remote-tracking branch 'upstream/master' into close-open-eatery # Conflicts: # src/main/java/seedu/address/logic/commands/CloseCommand.java # src/test/java/seedu/address/logic/commands/AddCommandTest.java # src/test/java/seedu/address/logic/commands/CloseCommandTest.java * Update DeveloperGuide with close feature (#82) * Update Developer Guide Updated Appendix A, B, C, D, E, F * Update Developer Guide Edited Appendix C (remove entry from todo). * Update DeveloperGuide.adoc with Close feature * Remove UndoSequenceDiagram * Remove trailing whitespaces from DeveloperGuide * Update DeveloperGuide.adoc * Review class (#77) * remove email field * Remove email field * Remove phone field * Remove phone attribute * Remove phone, email from test case * Resolve merge conflicts * Add basic version of Review class * Resolve merge conflicts with upstream * Fix checkstyle errors * Fix failing test cases * Fix failing tests * Verify test cases checking for similar eateries * Make reviews Json readable * Fix checkstyle errors and json adapted review errors * Make review changes permanent * Fix checkstyle errors * Fix checkstyle errors * Create set reviews method for eatery * Catch exceptions while parsing review command * Override equals method in review class * Improve code quality * Remove unused imports * Add `addfeed` command * Add `deletefeed` command * Add missing Javadocs * Add tests for feed-related commands * Update developer guide with add feature (#87) * Remove all instances of address * Add new command: Remark * Update UserGuide.adoc * Update UserGuide.adoc * Update Ui.png * Update UserGuide.adoc * Update Ui.png * Revert "Update Ui.png" This reverts commit 09529ff. * Revert "Update UserGuide.adoc" This reverts commit 1011cb1. * Revert "Update Ui.png" This reverts commit 43aa00b. * Revert "Update UserGuide.adoc" This reverts commit c907562. * Revert "Update UserGuide.adoc" This reverts commit ea7590c. * Revert "Merge branch 'tutorial-adding-command'" This reverts commit 3f671ae, reversing changes made to 5e1abfd. * Revert "Remove all instances of address" This reverts commit 5e1abfd. * Update UserGuide.adoc * Update UserGuide.adoc * Add activity and sequence diagram for Add command * Change sequence diagram * Change activity diagram * Resize activity diagram * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update DeveloperGuide.adoc * Update developer guide with Mode command details (#84) * Edit Developer Guide for Mode Command * Update developer guide * Update dg * Update Developer guide * Make changes to dg
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.