Add feed-related commands #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunHongT
approved these changes
Oct 23, 2019
Comment on lines
+72
to
77
| private void fetchPosts(ObservableList<FeedPost> feedPostList, List<Feed> feedList) { | ||
| Runnable feedPostFetch = () -> { | ||
| for (Feed feed : feedList.getFeedList()) { | ||
| for (Feed feed : feedList) { | ||
| ObservableList<FeedPost> feedPosts = feed.fetchPosts(); | ||
| Platform.runLater(() -> { | ||
| feedPostList.addAll(feedPosts); |
There was a problem hiding this comment.
What if the URL provided is not accurate? What will be the response given by the application?
Comment on lines
+32
to
+33
| String name = ParserUtil.parseName(argMultimap.getValue(PREFIX_NAME).get()).fullName; | ||
| String address = ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS).get()).value; |
There was a problem hiding this comment.
Will it be a huge hurdle to build a validation check before adding into the list? Personally believe that if the URL is wrong, then the application should not save it into the list in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addfeedanddeletefeedcommands