Update DG with implementation of add transaction #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into update-ppp
… into update-ppp
… into update-ppp
limerencee
force-pushed
the
update-ppp
branch
from
b66a476
to
2272ba0
Compare
lightz96
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Overall, it looks good to me.
However, your sequence diagram seems incorrect to me. For example, the activation bar in LogicManager did not break. The method name from LogicManager to ThriftParser should be parseCommand().
Also, you should change the color for the attributes in Income and Expense to something lighter in color. The color contrast seems bad to me.
I will merge this PR to improve workflow efficiency.
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.