Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UGDG #201

Merged
merged 1 commit into from Oct 28, 2019
Merged

Conversation

krusagiz
Copy link

  • Modified UG
  • Updated DG
  • Added AI to DG

Copy link

@limerencee limerencee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor changes

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved

Again, since the user input is valid, a `**UntagCommand**` command object is created and executed. As a result, a copy of the `**Transaction**` object without the specified `**Tag**` replaces the original in the `**TransactionList**` at the same position.
Again, since the user input is valid, a `**UntagCommand**` command object is created and executed. As a result, a copy of the `**Transaction**` object with the specified `**Tag**` deleted replaces the original in the `**TransactionList**` at the same position.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... with the specified deleted **Tag** replaces

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue with my current wording.

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
@@ -149,6 +149,8 @@ NOTE: Assume 2nd command occurs after 1st
[[TagTag]]
=== Tagging a transaction: `tag`

The `tag` command allows you to tag a `Transaction` entry.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**Transaction**

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it has been standardised in the document yet. We check again,

Copy link

@limerencee limerencee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after syncing the branch.

@limerencee limerencee merged commit f1c5190 into AY1920S1-CS2103T-W12-2:master Oct 28, 2019
kensonoenqh added a commit to kensonoenqh/main that referenced this pull request Oct 28, 2019
@krusagiz krusagiz deleted the ugdg-update branch October 28, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants