Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified UserGuide #267

Merged
merged 7 commits into from Nov 6, 2019
Merged

Modified UserGuide #267

merged 7 commits into from Nov 6, 2019

Conversation

krusagiz
Copy link

@krusagiz krusagiz commented Nov 5, 2019

Modified UserGuide.

Resolves #251

lightz96
lightz96 requested changes Nov 5, 2019
View reviewed changes
Copy link

@lightz96 lightz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Here are some general comments/suggestions:

  1. It seems like we have used both title case and sentence case for our title. E.g. Command summary and Quick Start
  2. Instead of "FAQ", maybe we should use "Frequently asked questions"

docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
docs/UserGuide.adoc Outdated Show resolved Hide resolved
@lightz96 lightz96 merged commit ba4a29f into AY1920S1-CS2103T-W12-2:master Nov 6, 2019
@krusagiz krusagiz deleted the ug branch November 7, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightz96 lightz96 lightz96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation does not inform user for what kind of currencies are aviable.
2 participants
@krusagiz @lightz96