Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kenson 1.4 #272

Merged
merged 13 commits into from Nov 8, 2019
Merged

Kenson 1.4 #272

merged 13 commits into from Nov 8, 2019

Conversation

kensonoenqh
Copy link

@kensonoenqh kensonoenqh commented Nov 7, 2019

ugdg edit, do check my sequence diagram, im not too sure if its accurate.

-edit. resolved boqiangs comments, further edited UGDG, added PPP, added some tests.

-edit merged master and minor updates

Copy link

@lightz96 lightz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR can merge once the feedback has been addressed.

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
@lightz96
Copy link

lightz96 commented Nov 8, 2019

image
is it possible to start the model's activation bar later?

@lightz96 lightz96 merged commit 3224ee2 into AY1920S1-CS2103T-W12-2:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants