Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser switching and sorting of transactions #137

Merged
merged 11 commits into from Oct 21, 2019

Conversation

weiyang13
Copy link

@weiyang13 weiyang13 commented Oct 19, 2019

Fixes #134

Expected behaviour:

  1. In one tab (e.g. transaction), the commands for another tab (e.g. badd from budget) will not work and give an unknown command message.
  2. Tab switching is done by keyboard shortcuts or clicking on the tab in the GUI. It can also be done through a command word (tx, rep, budget, analytics, loans). Regardless of how tab switching occurs, the above behaviour should hold.

Note: From above, we can immediately derive manual test cases for each mode of tab switching.

Unexpected problems encountered along the way:
In addition to what I described in #134 , I needed to define events for mouse clicking as it is not covered by the events for keyboard shortcut

Feel free to rename the command word for switching to your feature. It is stored in the respective ParserManager

Also, with this feature implemented, we can freely name the commands within our feature without worrying about conflicting with someone else. Use the ParserManager in your parser package to write the commands. However, right now the common commands (add, list, delete) as they are used by the existing Person feature, which is parsed directly by IchiFundParser

Edit: added sorting by date, then category, then description to fix #133

@weiyang13 weiyang13 added this to the v1.3 milestone Oct 19, 2019
@weiyang13 weiyang13 changed the title Parser switching Parser switching and sorting of transactions Oct 20, 2019
@weiyang13 weiyang13 removed the request for review from eugenood October 20, 2019 14:09
@LeeYiyuan LeeYiyuan merged commit 854df64 into AY1920S1-CS2103T-W12-4:master Oct 21, 2019
@weiyang13 weiyang13 self-assigned this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement context based parsing Implement automatic sorting of transactions by date
2 participants