Parser switching and sorting of transactions #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Expected behaviour:
badd
from budget) will not work and give an unknown command message.tx
,rep
,budget
,analytics
,loans
). Regardless of how tab switching occurs, the above behaviour should hold.Note: From above, we can immediately derive manual test cases for each mode of tab switching.
Unexpected problems encountered along the way:
In addition to what I described in #134 , I needed to define events for mouse clicking as it is not covered by the events for keyboard shortcut
Feel free to rename the command word for switching to your feature. It is stored in the respective
ParserManager
Also, with this feature implemented, we can freely name the commands within our feature without worrying about conflicting with someone else. Use the
ParserManager
in your parser package to write the commands. However, right now the common commands (add
,list
,delete
) as they are used by the existingPerson
feature, which is parsed directly byIchiFundParser
Edit: added sorting by date, then category, then description to fix #133