Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AddressBook -> ModuleBook #16

Merged
merged 25 commits into from Oct 9, 2019
Merged

Migrate AddressBook -> ModuleBook #16

merged 25 commits into from Oct 9, 2019

Conversation

CowSaysBaa
Copy link

@CowSaysBaa CowSaysBaa commented Oct 8, 2019 •
edited by geshuming

🔥 Major Changes 🔥

  • Rename all instances of Address/Person to Module
  • Remove unnecessary classes and functions.
  • Comment out failing tests (will need to reimplement as we proceed)

geshuming
geshuming previously requested changes Oct 8, 2019
View reviewed changes
Copy link

@geshuming geshuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Fix
A few major issues: (Rename person when not supposed to/Didn't rename person to module)

Won't Fix
Anything else. Whitespace problems, Storage, Parser, Tests

LICENSE Outdated Show resolved Hide resolved
docs/templates/LICENSE Outdated Show resolved Hide resolved
docs/tutorials/RemovingFields.adoc Outdated Show resolved Hide resolved
src/main/java/seedu/address/commons/core/Messages.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/commons/exceptions/IllegalValueException.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/Logic.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/FindCommand.java Show resolved Hide resolved
src/main/java/seedu/address/model/module/UniqueModuleList.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/storage/UserPrefsStorage.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/ui/HelpWindow.java Outdated Show resolved Hide resolved
@geshuming geshuming added priority.High Must do type.Story A user story labels Oct 8, 2019
@geshuming geshuming added this to the v1.2 milestone Oct 8, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 8, 2019
Closed
21 tasks
CowSaysBaa and others added 14 commits October 9, 2019 11:09
@CowSaysBaa
Merge branch 'master' of https://github.com/AY1920S1-CS2103T-W13-1/main
97f6e74 
# Conflicts:
#	docs/AboutUs.adoc (resolved)
@CowSaysBaa
Merge branch 'skeleton-branch' of https://github.com/CowSaysBaa/main
5c86884 
# Conflicts:
#	docs/UserGuide.adoc (resolved)
@CowSaysBaa
Remove tutorial.
bdebe4c 
Resolves issues related to naming and spacing.
@CowSaysBaa
Merge branch 'skeleton-branch' of https://github.com/CowSaysBaa/main …
1da41ee 
…into skeleton-branch

# Conflicts:
#	docs/UserGuide.adoc
#	docs/tutorials/RemovingFields.adoc
#	docs/tutorials/TracingCode.adoc
#	src/main/java/seedu/address/commons/core/Messages.java
#	src/main/java/seedu/address/logic/commands/FindCommand.java
#	src/main/java/seedu/address/model/module/UniqueModuleList.java
#	src/main/java/seedu/address/ui/HelpWindow.java
@CowSaysBaa
deleted tutorials
0350c01
@CowSaysBaa
Resolved issues with naming and spacing
ec938e2
@CowSaysBaa
Resolved whitespacing issue in JsonUtil.java
f77457f
@geshuming
Rename address/person -> module
396df32
@geshuming
Rename main package address -> module
69b41a3
@geshuming
Update build.gradle
6533541
@geshuming
Rename test package address -> module
7b404b3
@geshuming
Overhaul test package for migration to ModuleBook
2142002
@geshuming
Modify help window constants
3a35df1
@geshuming
Fix failing checkstyle issues
86a8e2e
@geshuming
Copy link

The AddressBook is now completely (codebase at least) migrated to ModuleBook. Failing tests are commented out for now.

@geshuming geshuming changed the title Skeleton branch Migrate AddressBook -> ModuleBook Oct 9, 2019
@geshuming geshuming dismissed their stale review October 9, 2019 13:46

Reviewer modified the code

alexwxh
alexwxh reviewed Oct 9, 2019
View reviewed changes
Copy link

@alexwxh alexwxh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good. a few minor changes needed here and there.

src/main/java/seedu/module/model/module/Module.java Show resolved Hide resolved
src/main/java/seedu/module/model/Model.java Outdated Show resolved Hide resolved
src/main/java/seedu/module/model/module/UniqueModuleList.java Outdated Show resolved Hide resolved
@alexwxh alexwxh merged commit 72fcba0 into AY1920S1-CS2103T-W13-1:master Oct 9, 2019
@CowSaysBaa CowSaysBaa deleted the skeleton-branch branch October 13, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geshuming geshuming geshuming left review comments

@alexwxh alexwxh alexwxh approved these changes

@bitterg0d bitterg0d Awaiting requested review from bitterg0d

@Kzrthikz Kzrthikz Awaiting requested review from Kzrthikz

Assignees
No one assigned
Labels
priority.High Must do type.Story A user story
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CowSaysBaa @geshuming @alexwxh