Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and delete command #33

Merged
merged 18 commits into from Oct 14, 2019
Merged

Add and delete command #33

merged 18 commits into from Oct 14, 2019

Conversation

CowSaysBaa
Copy link

Major changes

Unfinished

  • Test cases unimplemented.

CowSaysBaa and others added 18 commits September 29, 2019 15:18
@CowSaysBaa
added some images and changed AboutUs.adoc
af73025
@CowSaysBaa
updated photos and AboutUs.adoc
a1954ad
@CowSaysBaa
Added all photos and updated AboutUs.adoc
c56dff4
@CowSaysBaa
Merge branch 'master' of https://github.com/AY1920S1-CS2103T-W13-1/main
f3728b9
@CowSaysBaa
Merge branch 'master' of https://github.com/AY1920S1-CS2103T-W13-1/main
97f6e74 
# Conflicts:
#	docs/AboutUs.adoc (resolved)
@CowSaysBaa
Merge branch 'master' of https://github.com/AY1920S1-CS2103T-W13-1/main
6e04c0b
@CowSaysBaa
Merge branch 'master' of https://github.com/CowSaysBaa/main
87d2ac4
@CowSaysBaa
Merge branch 'master' of https://github.com/AY1920S1-CS2103T-W13-1/main
8ec5206
@CowSaysBaa
Fixed DeleteCommand.java.
e9242a8 
DeleteCommand should now work.
@CowSaysBaa
Changed the fields and accessors within TrackedModule.java.
259c12a
@CowSaysBaa
Deleted ArchiveStub.
4c70937 
TrackedModule now reference ArchivedModule.
Changed how add command works.
@geshuming
Require ModuleBook to init with ArchivedModuleList
bfebc88
@geshuming
Fix JsonAdaptedModule
646cff9
@geshuming
Fix checkstyle issues
448e959
@geshuming
Delete SampleDataUtil
1885578
@geshuming
Simplify ModuleBook constructor
e227952
@geshuming
Fix ModuleBook not initializing with archived modules
9c46ddf
@geshuming
Fix Add Command not refreshing displayed list
e5c5f89
@CowSaysBaa CowSaysBaa added priority.High Must do type.Story A user story labels Oct 13, 2019
@CowSaysBaa CowSaysBaa added this to the v1.2 milestone Oct 13, 2019
@geshuming geshuming requested review from alexwxh, bitterg0d and Kzrthikz and removed request for geshuming October 13, 2019 09:53
geshuming added a commit to geshuming/main that referenced this pull request Oct 13, 2019
@geshuming
Update StorageClassDiagram for AY1920S1-CS2103T-W13-1#33
93a8bf3
Kzrthikz
Kzrthikz approved these changes Oct 14, 2019
View reviewed changes
Copy link

@Kzrthikz Kzrthikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kzrthikz Kzrthikz merged commit e907915 into AY1920S1-CS2103T-W13-1:master Oct 14, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 16, 2019
Closed
26 tasks
geshuming added a commit that referenced this pull request Oct 21, 2019
@geshuming
Update StorageClassDiagram and DeveloperGuide (#30)
198d489 
* Update Storage Diagram

* Update StorageClassDiagram for #33

* Fix arrow showing extension instead of dependency

* Update DeveloperGuide
geshuming added a commit to geshuming/main that referenced this pull request Nov 7, 2019
@geshuming
Attribute code from AY1920S1-CS2103T-W13-1#33
8c6b892
@geshuming geshuming mentioned this pull request Nov 7, 2019
Merged
geshuming added a commit that referenced this pull request Nov 7, 2019
@geshuming
Attribute code from #33 (#155)
6791186
@CowSaysBaa CowSaysBaa deleted the Add-Delete-Command branch November 10, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kzrthikz Kzrthikz Kzrthikz approved these changes

@alexwxh alexwxh Awaiting requested review from alexwxh

@bitterg0d bitterg0d Awaiting requested review from bitterg0d

Assignees
No one assigned
Labels
priority.High Must do type.Story A user story
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As a student, I want to delete a module As a student, I want to add a module
3 participants
@CowSaysBaa @Kzrthikz @geshuming