Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsonArchivedModuleList #44

Merged
merged 1 commit into from Oct 17, 2019
Merged

Fix JsonArchivedModuleList #44

merged 1 commit into from Oct 17, 2019

Conversation

geshuming
Copy link

Fix #41

The JsonArchivedModuleList class now reads from the resource file directly, and does not require a URI conversion

@geshuming geshuming added type.Bug A bug priority.High Must do severity.High A flaw that affects most users and causes major problems labels Oct 16, 2019
CowSaysBaa
CowSaysBaa approved these changes Oct 17, 2019
View reviewed changes
Copy link

@CowSaysBaa CowSaysBaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geshuming geshuming merged commit 3895598 into AY1920S1-CS2103T-W13-1:master Oct 17, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 22, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CowSaysBaa CowSaysBaa CowSaysBaa approved these changes

@alexwxh alexwxh Awaiting requested review from alexwxh

Assignees
No one assigned
Labels
priority.High Must do severity.High A flaw that affects most users and causes major problems type.Bug A bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jar build unable to read archived modules
2 participants
@geshuming @CowSaysBaa