Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for model package #68

Merged
merged 3 commits into from Oct 24, 2019
Merged

Update tests for model package #68

merged 3 commits into from Oct 24, 2019

Conversation

geshuming
Copy link

@geshuming geshuming added type.Task Something that needs to be done, but not a story, bug, or an epic priority.Low Unlikely to do labels Oct 24, 2019
CowSaysBaa
CowSaysBaa approved these changes Oct 24, 2019
View reviewed changes
src/test/java/seedu/module/model/ModelManagerTest.java
assertFalse(modelManager.equals(new ModelManager(differentModuleBook, userPrefs)));

// different filteredList -> returns false
// String[] keywords = ALICE.getName().fullName.split("\\s+");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not seem necessary.

@geshuming geshuming merged commit 65a8531 into AY1920S1-CS2103T-W13-1:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CowSaysBaa CowSaysBaa CowSaysBaa approved these changes

Assignees
No one assigned
Labels
priority.Low Unlikely to do type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geshuming @CowSaysBaa