Jhchen/ft manage account #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-fung
reviewed
Nov 3, 2019
Comment on lines
113
to
173
| @Override | ||
| public String toString() { | ||
| return getName().toString() + " (" + getDescription().toString() + ")"; | ||
| } |
There was a problem hiding this comment.
I don't think the user will ever see the result of toString(), so up to you if you want to add the balance in it too.
tcgj
reviewed
Nov 3, 2019
src/main/java/budgetbuddy/model/transaction/TransactionList.java
Outdated
Show resolved
Hide resolved
src/main/java/budgetbuddy/model/transaction/TransactionList.java
Outdated
Show resolved
Hide resolved
tcgj
reviewed
Nov 4, 2019
Comment on lines
+84
to
+85
| checkBalanceValidity(balance = balance + toAdd.getAmount().toLong()); | ||
| balance = balance + toAdd.getAmount().toLong(); | ||
| } else { | ||
| checkBalanceValidity(balance = balance - toAdd.getAmount().toLong()); | ||
| balance = balance - toAdd.getAmount().toLong(); |
There was a problem hiding this comment.
Not sure why there's assignment within the arguments here
thaowei
force-pushed
the
jhchen/ft-manage-account
branch
from
cf1c3d9
to
83ddc65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add balance field to the account
(currently all other account commands are able to update the balance displayed in the list.. except for account list... )
closes #136