Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jhchen/ft manage account #183

Merged
merged 7 commits into from Nov 7, 2019
Merged

Jhchen/ft manage account #183

merged 7 commits into from Nov 7, 2019

Conversation

ChenJiehan318
Copy link

  1. implement account report command and parser

  2. implement account overview command and parser (generate html report for all accounts)

@coveralls
Copy link

coveralls commented Nov 6, 2019 •
edited

Coverage Status

Coverage decreased (-0.6%) to 41.629% when pulling 08c2318 on jhchen/ft-manage-account into b769c76 on master.

kenneth-fung
kenneth-fung reviewed Nov 6, 2019
View reviewed changes
Copy link

@kenneth-fung kenneth-fung left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. But I really think the IOException should be caught, see the comment below.

Also, make sure to add the /exports/ folder to .gitignore.

src/main/java/budgetbuddy/logic/commands/accountcommands/AccountOverviewCommand.java Outdated Show resolved Hide resolved
@kenneth-fung kenneth-fung merged commit ef3d61b into master Nov 7, 2019
@thaowei thaowei added this to the v1.4 milestone Nov 10, 2019
This was referenced Nov 13, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenneth-fung kenneth-fung kenneth-fung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChenJiehan318 @coveralls @kenneth-fung @thaowei