Make GUI great again #185
Merged
Make GUI great again #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcgj
commented
Nov 7, 2019
tcgj
commented
- Remove image dependency for tabs
- Remove alternating list item colours
- Fix script card not using cardPane style class
- Fix transaction card using redundant for loop
- Fix rule card's overflowing action value overlapping on predicate
thaowei
approved these changes
Nov 7, 2019
Comment on lines
45
to
49
| if (account.isActive()) { | ||
| accountCard.getRoot().setStyle("-fx-background-color: #005F83"); | ||
| accountCard.getRoot().setStyle("-fx-background-color: #282547"); | ||
| } else { | ||
| accountCard.getRoot().setStyle("-fx-background-color: null"); | ||
| accountCard.getRoot().setStyle("-fx-background-color: #52667d"); | ||
| } |
There was a problem hiding this comment.
I agree but I couldn't find a way... alternatively I could setId instead of specific colour.
| setGraphic(currImage); | ||
| // Create tab | ||
| Stop[] stops = new Stop[] { new Stop(0, Color.web("#3f556f")), new Stop(1, Color.web("#2c3b4d"))}; | ||
| LinearGradient lg = new LinearGradient(0, 0, 0, 1, true, CycleMethod.NO_CYCLE, stops); |
There was a problem hiding this comment.
This should probably be done in CSS too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.