Improve transaction commands #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcgj
reviewed
Oct 29, 2019
docs/UserGuide.adoc
Outdated
|
|
||
| Edits the specified transaction, setting the specified fields. | ||
| Edits the specified txn, setting the specified fields. |
There was a problem hiding this comment.
for text perhaps use "transaction" instead?
docs/UserGuide.adoc
Outdated
|
|
||
| Deletes the transactions with the specified IDs. | ||
| Deletes the txn with the specified ID. |
src/main/java/budgetbuddy/logic/commands/transactioncommands/TransactionDeleteCommand.java
Show resolved
Hide resolved
…ion of transactions
…rebasing changes.
thaowei
force-pushed
the
cambrian-dk/ft-transactions
branch
from
67520b2
to
45b3dfa
Compare
thaowei
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Two issues:
The default account handling is very weird. It should definitely not be kept as a static field in AccountsManager.
Transaction add also doesn't work. TransactionAddCommandParser calls CommandParserUtil#parseAccount which creates a new Account, and then sets, on the Transaction, the Account. Then TransactionAddCommand calls AccountsManager#addTransaction, which gets the Account set on the Transaction, adds the Transaction to that account, and then the Account is promptly lost.
I'm going to merge first, and we can fix it after the other PR is merged.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.