Skip to content

Commit

Permalink
Merge pull request #163 from JingYuOng/LogicManagerTest
Browse files Browse the repository at this point in the history
JY PPP
  • Loading branch information
seanlowcy77 committed Apr 13, 2020
2 parents d004a07 + 6dd7b06 commit 5a4818b
Showing 1 changed file with 85 additions and 0 deletions.
85 changes: 85 additions & 0 deletions docs/team/OngJingYu.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
= Ong Jing Yu - Project Portfolio
:site-section: AboutUs
:imagesDir: ../images
:stylesDir: ../stylesheets

== PROJECT: Modulo

---

== Overview

AddressBook - Level 3 is a desktop address book application used for teaching Software Engineering principles.
The user interacts with it using a CLI, and it has a GUI created with JavaFX. It is written in Java, and has about 10 kLoC.

== Summary of contributions

* *Major enhancement*: added *the ability to update a deadline status to be done or not done*
** What it does: allows the user to keep track of their deadlines and update them easily.
When user added module and events, a deadline will be auto populated to each event.
Therefore, user can view the deadline for every week and update them if it is not completed.
This actually help user not to miss any assignment and deadline.

** Justification: When user added module and events, a deadline will be auto populated to each event.
Therefore, user can view the deadline for every week and update them if it is not completed.
This actually help user not to miss any assignment and deadline.
** Highlights: This features required multi layer of checking for modules and events in order to update the status of the deadline.

* *Minor enhancement*: Implemented the right panel for UI and wire up the logic for viewing details for modules / details + deadlines for events

* *Code contributed*: [https://nus-cs2103-ay1920s2.github.io/tp-dashboard/#search=JingYu&sort=totalCommits%20dsc&sortWithin=title&since=2020-02-14&timeframe=commit&mergegroup=false&groupSelect=groupByRepos&breakdown=false[Functional code]]
* *Test Case'code contributed*: +
** [https://github.com/AY1920S2-CS2103-T09-1/main/pull/126[ParserUtil Test]]
** [https://github.com/AY1920S2-CS2103-T09-1/main/pull/122[Model Event Test]]
** [https://github.com/AY1920S2-CS2103-T09-1/main/pull/143[View & CommandTest]]

* *Other contributions*:

** Project management:
*** Reviewed and merged teammates' pull requests
** Enhancements to existing features:
*** Fixed failed test cases (Pull requests https://github.com/AY1920S2-CS2103-T09-1/main/pull/141[#141])
** Documentation:
*** Added use case in Developer Guide: https://github.com/AY1920S2-CS2103-T09-1/main/pull/153[#14]
*** Updated Developer Guide with implemented feature: https://github.com/AY1920S2-CS2103-T09-1/main/pull/152[#152]
*** Update feature in user guide https://github.com/AY1920S2-CS2103-T09-1/main/pull/80[#80]
*** Added UML diagram for Developer Guide https://github.com/AY1920S2-CS2103-T09-1/main/pull/77[#77]

** Community:
*** PRs reviewed (with non-trivial review comments): https://github.com/AY1920S2-CS2103-T09-1/main/pull/134[#134], https://github.com/AY1920S2-CS2103-T09-1/main/pull/151[#151]
*** Contributed to forum discussions (examples: https://github.com/nus-cs2103-AY1920S2/forum/issues/57[#57)




== Contributions to the User Guide

|===
|_Given below are sections I contributed to the User Guide. They showcase my ability to write documentation targeting end-users._
|===

include::../UserGuide.adoc[tag=done]

== Contributions to the Developer Guide

|===
|_Given below are sections I contributed to the Developer Guide. They showcase my ability to write technical documentation and the technical depth of my contributions to the project._
|===

include::../DeveloperGuide.adoc[tag=ucfive]

include::../DeveloperGuide.adoc[tag=ucsix]

include::../DeveloperGuide.adoc[tag=ucseven]

include::../DeveloperGuide.adoc[tag=uceight]

include::../DeveloperGuide.adoc[tag=ucnine]

include::../DeveloperGuide.adoc[tag=done]

== PROJECT: PowerPointLabs

---

_{Optionally, you may include other projects in your portfolio.}_

0 comments on commit 5a4818b

Please sign in to comment.