-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various hotfixes for v1.3 #137
Conversation
@@ -41,6 +41,7 @@ public PersonalBestTable(ObservableList<Exercise> e) { | |||
exerciseDate.setCellValueFactory(new PropertyValueFactory<Exercise, String>("exerciseDate")); | |||
exerciseWeight.setCellValueFactory(new PropertyValueFactory<Exercise, String>("exerciseWeight")); | |||
exerciseReps.setCellValueFactory(new PropertyValueFactory<Exercise, String>("exerciseReps")); | |||
exerciseName.setText("Personal Best Exercise"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest moving this to fxml for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, please kindly do it for me =D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn
@@ -5,8 +5,8 @@ | |||
|
|||
<TableView fx:id="tableView" prefHeight="200.0" prefWidth="250.0" xmlns="http://javafx.com/javafx/11.0.1" xmlns:fx="http://javafx.com/fxml/1"> | |||
<columns> | |||
<TableColumn fx:id="exerciseName" editable="false" minWidth="200.0" prefWidth="200.0" reorderable="false" text="Exercise" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest text="Personal Best Exercise"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.