Add birthday attribute and tests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-implemented BirthdayTest
|
fail test coverage, add more tests or uwuhan |
…3T-F11-2/main into BirthdayAttribute
|
Improved coverage. |
AaronCQL
reviewed
Mar 11, 2020
ziyingli
reviewed
Mar 12, 2020
Comment on lines
+49
to
+54
| // valid birthday | ||
| assertTrue(Birthday.isValidBirthday("01-01-1980")); // birthday in 01-01-1980 | ||
| assertTrue(Birthday.isValidBirthday("01-01-1970")); //birthday in 01-01-1979 | ||
|
|
||
| assertTrue(new Birthday("01-01-1980").hashCode() == new Birthday("01-01-1980").hashCode()); | ||
| assertTrue(new Birthday("01-01-1980").toString().equals("01-01-1980") == true); |
21 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-implemented Birthday and BirthdayTest
A valid birthday satisfies the following:
-in the format "DD-MM-YYYY"
-input date is earlier than the current date
BirthdayTest includes a hard-coded test case for a birthday on 1st January 1980.