Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StudentRecordList part in DG #199

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

sc-arecrow
Copy link
Collaborator

Update StudentRecordList part in DG

Summary

Let's include the design considerations and alternatives for the
implementation of StudentRecordList.

Type of change

<Select all that apply, in the form [x]>

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Let's include the design considerations and alternatives for the
implementation of StudentRecordList.
@sc-arecrow sc-arecrow added this to the v1.4 milestone Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage     79.33%   79.33%           
  Complexity      674      674           
=========================================
  Files            94       94           
  Lines          1936     1936           
  Branches        238      238           
=========================================
  Hits           1536     1536           
  Misses          296      296           
  Partials        104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ad52d...768d55f. Read the comment docs.

Copy link

@jaya-r3 jaya-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaya-r3 jaya-r3 merged commit 8e2c0c5 into AY2021S1-CS2103-F09-1:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants