Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.2.3] Branch refactor person class #105

Merged

Conversation

esmanda3w
Copy link

No description provided.

@esmanda3w esmanda3w added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 7, 2020
@esmanda3w esmanda3w added this to the v1.2 milestone Oct 7, 2020
@esmanda3w esmanda3w linked an issue Oct 8, 2020 that may be closed by this pull request
# Conflicts:
#	src/main/java/seedu/address/logic/commands/AddCommand.java
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/commands/ListCommand.java
#	src/main/java/seedu/address/logic/parser/AddCommandParser.java
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
#	src/main/java/seedu/address/logic/parser/ParserUtil.java
#	src/main/java/seedu/address/model/investigationcase/Address.java
#	src/main/java/seedu/address/model/investigationcase/Case.java
#	src/main/java/seedu/address/model/investigationcase/Email.java
#	src/main/java/seedu/address/model/investigationcase/NameContainsKeywordsPredicate.java
#	src/main/java/seedu/address/model/investigationcase/Phone.java
#	src/main/java/seedu/address/model/util/SampleDataUtil.java
#	src/main/java/seedu/address/storage/JsonAdaptedCase.java
#	src/main/java/seedu/address/ui/PersonCard.java
#	src/test/java/seedu/address/logic/LogicManagerTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/commands/EditCaseDescriptorTest.java
#	src/test/java/seedu/address/logic/commands/EditCommandTest.java
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/EditCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/ParserUtilTest.java
#	src/test/java/seedu/address/model/AddressBookTest.java
#	src/test/java/seedu/address/model/ModelManagerTest.java
#	src/test/java/seedu/address/model/investigationcase/AddressTest.java
#	src/test/java/seedu/address/model/investigationcase/CaseTest.java
#	src/test/java/seedu/address/model/investigationcase/EmailTest.java
#	src/test/java/seedu/address/model/investigationcase/PhoneTest.java
#	src/test/java/seedu/address/model/person/UniquePersonListTest.java
#	src/test/java/seedu/address/storage/JsonAdaptedCaseTest.java
#	src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/PersonBuilder.java
#	src/test/java/seedu/address/testutil/PersonUtil.java
#	src/test/java/seedu/address/testutil/TypicalPersons.java
@codecov-io
Copy link

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 84.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage     71.31%   71.31%           
  Complexity      435      435           
=========================================
  Files            81       81           
  Lines          1433     1433           
  Branches        151      151           
=========================================
  Hits           1022     1022           
  Misses          349      349           
  Partials         62       62           
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.15% <ø> (ø) 10.00 <0.00> (ø)
.../address/model/investigationcase/Alphanumeric.java 72.72% <ø> (ø) 8.00 <0.00> (?)
...u/address/model/investigationcase/Description.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...eedu/address/model/investigationcase/Document.java 69.23% <ø> (ø) 5.00 <0.00> (?)
...va/seedu/address/model/investigationcase/Name.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...edu/address/model/investigationcase/Reference.java 76.92% <ø> (ø) 5.00 <0.00> (?)
.../seedu/address/model/investigationcase/Status.java 100.00% <ø> (ø) 5.00 <0.00> (?)
...seedu/address/model/investigationcase/Suspect.java 0.00% <ø> (ø) 0.00 <0.00> (?)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f00d59...a08a537. Read the comment docs.

Copy link

@Vielheim Vielheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vielheim Vielheim merged commit 0061240 into AY2021S1-CS2103-F09-2:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.2.3] Refactor Person class to Case
3 participants