Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.2.4] Change DeleteCommand Class into abstract class #114

Merged
merged 4 commits into from
Oct 12, 2020
Merged

[v1.2.4] Change DeleteCommand Class into abstract class #114

merged 4 commits into from
Oct 12, 2020

Conversation

Jargonx
Copy link

@Jargonx Jargonx commented Oct 11, 2020

Closes #113

@Jargonx Jargonx added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 11, 2020
@Jargonx Jargonx added this to the v1.2 milestone Oct 11, 2020
@Jargonx Jargonx changed the title Change DeleteCommand Class into abstract class [v1.2.4] Change DeleteCommand Class into abstract class Oct 11, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0061240). Click here to learn what that means.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage          ?   71.21%           
  Complexity        ?      435           
=========================================
  Files             ?       82           
  Lines             ?     1435           
  Branches          ?      151           
=========================================
  Hits              ?     1022           
  Misses            ?      350           
  Partials          ?       63
Impacted Files Coverage Δ Complexity Δ
...eedu/address/logic/parser/DeleteCommandParser.java 69.23% <66.66%> (ø) 2.00 <0.00> (?)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø) 5.00 <1.00> (?)
...logic/commands/casecommands/DeleteCaseCommand.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0061240...dab5440. Read the comment docs.

@Jargonx Jargonx self-assigned this Oct 12, 2020
constancensq
constancensq approved these changes Oct 12, 2020
View reviewed changes
Copy link

@constancensq constancensq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constancensq constancensq merged commit 95356b5 into AY2021S1-CS2103-F09-2:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constancensq constancensq constancensq approved these changes

Assignees

@Jargonx Jargonx

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

[v1.2.4] Change DeleteCommand class into abstract class
3 participants
@Jargonx @codecov-io @constancensq