[v1.2.4] Make list command abstract #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constancensq
commented
Oct 12, 2020
constancensq
commented
- Abstract List command
- Created ListCaseCommand class
- Checked state to ensure is at main page before returning command
…into branch-abstract-list-case-command * 'master' of https://github.com/AY2021S1-CS2103-F09-2/tp: Update State of program with OpenCaseCommand Add OpenCase Command. Update StateManager.java Add StateManager to PIVOT
constancensq
changed the title
CodyChew
reviewed
Oct 12, 2020
| @@ -28,7 +32,10 @@ public ListCommand parse(String args) throws ParseException { | |||
| throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, ListCommand.MESSAGE_USAGE)); | |||
| } | |||
|
|
|||
| return new ListCommand(); | |||
| if (StateManager.getState() != null) { | |||
There was a problem hiding this comment.
Should use the atMainPage()/atCasePage() check here rather than checking the element
CodyChew
added
priority.High
…into branch-abstract-list-case-command * 'master' of https://github.com/AY2021S1-CS2103-F09-2/tp: Update equals, remove abstract execute DeleteCommand Check for State before Deleting Case Add Return Command Update files using CheckStyle Integrate StateManager with GUI Add integration for StateManager with MainWindow.java (NOT COMPLETE) Update GUI to display Documents, Suspects, Witnesses and Victims Update GUI to display Documents DeleteCommand Class is now abstract, DeleteCaseCommand added Add id to labels in fxml fields in MainWindow.fxml Add panes for Case fields in MainWindow.fxml Edit layout in MainWindow.fxml Adjust layout for GUI Edit layout in MainWindow.fxml Edit layout in MainWindow.fxml Add SplitPane layout in MainWindow.fxml # Conflicts: # src/main/java/seedu/address/commons/core/Messages.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.