Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.2.5] Add and Delete Witness #133

Merged

Conversation

Jargonx
Copy link

@Jargonx Jargonx commented Oct 14, 2020

Closes #15 #9

@Jargonx Jargonx added type.Epic A big feature which can be broken down into smaller stories e.g. search priority.High Must do labels Oct 14, 2020
@Jargonx Jargonx added this to the v1.2 milestone Oct 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #133 into master will decrease coverage by 1.97%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     58.74%   56.77%   -1.98%     
  Complexity      443      443              
============================================
  Files           102      105       +3     
  Lines          1755     1816      +61     
  Branches        201      212      +11     
============================================
  Hits           1031     1031              
- Misses          656      717      +61     
  Partials         68       68              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ic/commands/witnesscommands/AddWitnessCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...commands/witnesscommands/DeleteWitnessCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/address/logic/parser/AddCommandParser.java 24.00% <0.00%> (-1.00%) 3.00 <0.00> (ø)
.../address/logic/parser/AddWitnessCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/parser/DeleteCommandParser.java 32.35% <0.00%> (-0.99%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bc1fa...d9c4ef6. Read the comment docs.

Copy link

@Vielheim Vielheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vielheim Vielheim merged commit 949913d into AY2021S1-CS2103-F09-2:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Epic A big feature which can be broken down into smaller stories e.g. search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Witness from Investigation Case
3 participants