Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.1] Code Quality and Standardisation #138

Merged

Conversation

Vielheim
Copy link

No description provided.

@Vielheim Vielheim added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 18, 2020
@Vielheim Vielheim added this to the v1.3 milestone Oct 18, 2020
@Vielheim Vielheim self-assigned this Oct 18, 2020
@Vielheim Vielheim linked an issue Oct 18, 2020 that may be closed by this pull request
…nch-refactor-CodeQuality

* 'master' of github.com:AY2021S1-CS2103-F09-2/tp:
  Refactor AddressBook to Pivot in tests
  Refactor AddressBook to PIVOT
  Update User Guide

# Conflicts:
#	src/main/java/seedu/pivot/logic/commands/ClearCommand.java
#	src/main/java/seedu/pivot/logic/commands/EditCommand.java
#	src/main/java/seedu/pivot/logic/commands/casecommands/AddCaseCommand.java
#	src/main/java/seedu/pivot/logic/commands/casecommands/AddDescriptionCommand.java
#	src/main/java/seedu/pivot/logic/commands/documentcommands/AddDocumentCommand.java
#	src/main/java/seedu/pivot/logic/commands/victimcommands/AddVictimCommand.java
#	src/main/java/seedu/pivot/logic/commands/witnesscommands/AddWitnessCommand.java
#	src/main/java/seedu/pivot/logic/parser/AddCaseCommandParser.java
#	src/test/java/seedu/address/logic/commands/ClearCommandTest.java
…nch-refactor-CodeQuality

* 'master' of github.com:AY2021S1-CS2103-F09-2/tp:
  Improve code quality
  Improve error messages

# Conflicts:
#	src/main/java/seedu/pivot/logic/parser/ParserUtil.java
#	src/main/java/seedu/pivot/storage/JsonAdaptedWitness.java
Bug fix: Change unmodifiable list to return a copy
Copy link

@constancensq constancensq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constancensq constancensq merged commit 9036877 into AY2021S1-CS2103-F09-2:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3.1] Code Quality and Standardisation
2 participants