forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.3.1] Code Quality and Standardisation #138
Merged
constancensq
merged 8 commits into
AY2021S1-CS2103-F09-2:master
from
Vielheim:branch-refactor-CodeQuality
Oct 22, 2020
Merged
[v1.3.1] Code Quality and Standardisation #138
constancensq
merged 8 commits into
AY2021S1-CS2103-F09-2:master
from
Vielheim:branch-refactor-CodeQuality
Oct 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:AY2021S1-CS2103-F09-2/tp: Update Message Usages for Commands
Save for testing
Vielheim
added
type.Task
Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
priority.High
Must do
labels
Oct 18, 2020
…nch-refactor-CodeQuality * 'master' of github.com:AY2021S1-CS2103-F09-2/tp: Refactor AddressBook to Pivot in tests Refactor AddressBook to PIVOT Update User Guide # Conflicts: # src/main/java/seedu/pivot/logic/commands/ClearCommand.java # src/main/java/seedu/pivot/logic/commands/EditCommand.java # src/main/java/seedu/pivot/logic/commands/casecommands/AddCaseCommand.java # src/main/java/seedu/pivot/logic/commands/casecommands/AddDescriptionCommand.java # src/main/java/seedu/pivot/logic/commands/documentcommands/AddDocumentCommand.java # src/main/java/seedu/pivot/logic/commands/victimcommands/AddVictimCommand.java # src/main/java/seedu/pivot/logic/commands/witnesscommands/AddWitnessCommand.java # src/main/java/seedu/pivot/logic/parser/AddCaseCommandParser.java # src/test/java/seedu/address/logic/commands/ClearCommandTest.java
…nch-refactor-CodeQuality * 'master' of github.com:AY2021S1-CS2103-F09-2/tp: Improve code quality Improve error messages # Conflicts: # src/main/java/seedu/pivot/logic/parser/ParserUtil.java # src/main/java/seedu/pivot/storage/JsonAdaptedWitness.java
Bug fix: Change unmodifiable list to return a copy
constancensq
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority.High
Must do
type.Task
Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.