Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.2] Add support for Opening Document #155

Merged
merged 6 commits into from
Oct 25, 2020

Conversation

CodyChew
Copy link

@CodyChew CodyChew commented Oct 25, 2020

  • OpenCommand only has Case and Doc types with one argument, so there is only one parser to return the appropriate commands
  • OpenDocumentCommand checks for valid index and tries to open the doc
  • CommandExceptions thrown:
    • invalid document index
    • reference does not exist
    • error opening file
    • Desktop API not supported

@CodyChew CodyChew added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 25, 2020
@CodyChew CodyChew added this to the v1.3 milestone Oct 25, 2020
@CodyChew CodyChew self-assigned this Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #155 into master will decrease coverage by 0.93%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
- Coverage     55.29%   54.36%   -0.94%     
- Complexity      501      502       +1     
============================================
  Files           115      116       +1     
  Lines          2217     2255      +38     
  Branches        299      304       +5     
============================================
  Hits           1226     1226              
- Misses          858      895      +37     
- Partials        133      134       +1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/pivot/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/pivot/commons/util/FileUtil.java 59.37% <0.00%> (-16.63%) 11.00 <0.00> (+1.00) ⬇️
.../main/java/seedu/pivot/logic/commands/Command.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...commands/documentcommands/OpenDocumentCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/seedu/pivot/logic/parser/OpenCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/pivot/model/investigationcase/Reference.java 56.25% <0.00%> (-3.75%) 5.00 <0.00> (ø)
...ain/java/seedu/pivot/storage/ReferenceStorage.java 71.42% <ø> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690e4d5...21d4204. Read the comment docs.

Copy link

@Vielheim Vielheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vielheim Vielheim merged commit f1d37b7 into AY2021S1-CS2103-F09-2:master Oct 25, 2020
@CodyChew CodyChew linked an issue Oct 25, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Document in Investigation Case
3 participants