-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.3.2] Add support for Opening Document #155
[v1.3.2] Add support for Opening Document #155
Conversation
CodyChew
commented
Oct 25, 2020
•
edited
edited
- OpenCommand only has Case and Doc types with one argument, so there is only one parser to return the appropriate commands
- OpenDocumentCommand checks for valid index and tries to open the doc
- CommandExceptions thrown:
- invalid document index
- reference does not exist
- error opening file
- Desktop API not supported
…into branch-open-document
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
- Coverage 55.29% 54.36% -0.94%
- Complexity 501 502 +1
============================================
Files 115 116 +1
Lines 2217 2255 +38
Branches 299 304 +5
============================================
Hits 1226 1226
- Misses 858 895 +37
- Partials 133 134 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM