Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.3.2] Augment find #156

Merged
merged 9 commits into from
Oct 25, 2020
Merged

[v1.3.2] Augment find #156

merged 9 commits into from
Oct 25, 2020

Conversation

constancensq
Copy link

  • Change behaviour of find to search all details of all cases
  • Remove updatefilteredcaselist with all cases predicate for add docs/desc/witness/suspect/victim commands
  • Edit UI so that Person details are shown beter

@codecov-io
Copy link

Codecov Report

Merging #156 into master will increase coverage by 0.10%.
The diff coverage is 66.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     55.29%   55.40%   +0.10%     
- Complexity      501      520      +19     
============================================
  Files           115      116       +1     
  Lines          2217     2274      +57     
  Branches        299      316      +17     
============================================
+ Hits           1226     1260      +34     
- Misses          858      880      +22     
- Partials        133      134       +1
Impacted Files Coverage Δ Complexity Δ
...va/seedu/pivot/commons/core/DeveloperMessages.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/pivot/commons/core/UserMessages.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/pivot/logic/commands/ReturnCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ot/logic/commands/casecommands/AddCaseCommand.java 88.23% <0.00%> (ø) 8.00 <0.00> (ø)
...c/commands/casecommands/AddDescriptionCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...t/logic/commands/casecommands/OpenCaseCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../commands/documentcommands/AddDocumentCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mmands/documentcommands/DeleteDocumentCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/commands/suspectcommands/AddSuspectCommand.java 28.57% <0.00%> (+0.98%) 3.00 <0.00> (ø)
...commands/suspectcommands/DeleteSuspectCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690e4d5...ebc0b85. Read the comment docs.

@constancensq constancensq changed the title Augment find [v1.3.2] Augment find Oct 25, 2020
@constancensq
Merge branch 'master' of https://github.com/AY2021S1-CS2103-F09-2/tp …
18fb87e 
…into branch-augment-find

* 'master' of https://github.com/AY2021S1-CS2103-F09-2/tp:
  Add Checks for Desktop API support
  Update logger info
  Add Open Document functionality

# Conflicts:
#	src/main/java/seedu/pivot/logic/parser/OpenCommandParser.java
Vielheim
Vielheim approved these changes Oct 25, 2020
View reviewed changes
Copy link

@Vielheim Vielheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vielheim Vielheim merged commit 8522436 into AY2021S1-CS2103-F09-2:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vielheim Vielheim Vielheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@constancensq @codecov-io @Vielheim