Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.2] Add Parser Test Cases #160

Merged

Conversation

Jargonx
Copy link

@Jargonx Jargonx commented Oct 25, 2020

Closes #159

@Jargonx Jargonx added type.Enhancement An enhancement to an existing story priority.High Must do labels Oct 25, 2020
@Jargonx Jargonx added this to the v1.3 milestone Oct 25, 2020
@Jargonx Jargonx self-assigned this Oct 25, 2020
@Jargonx Jargonx changed the title Add Parser Test Cases [v1.3.2] Add Parser Test Cases Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #160 into master will increase coverage by 3.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     65.18%   68.44%   +3.25%     
- Complexity      664      697      +33     
============================================
  Files           122      122              
  Lines          2424     2424              
  Branches        340      340              
============================================
+ Hits           1580     1659      +79     
+ Misses          711      614      -97     
- Partials        133      151      +18     
Impacted Files Coverage Δ Complexity Δ
...java/seedu/pivot/logic/commands/DeleteCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../seedu/pivot/logic/parser/DeleteCommandParser.java 80.00% <ø> (+53.33%) 12.00 <0.00> (+8.00)
...edu/pivot/model/investigationcase/Description.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...n/java/seedu/pivot/logic/commands/OpenCommand.java 60.00% <0.00%> (ø) 2.00% <0.00%> (+1.00%)
...main/java/seedu/pivot/logic/parser/ParserUtil.java 82.53% <0.00%> (+9.52%) 19.00% <0.00%> (+2.00%)
...ava/seedu/pivot/logic/parser/AddCommandParser.java 53.57% <0.00%> (+28.57%) 9.00% <0.00%> (+5.00%)
...va/seedu/pivot/logic/parser/OpenCommandParser.java 53.84% <0.00%> (+53.84%) 3.00% <0.00%> (+3.00%)
...u/pivot/logic/parser/AddDocumentCommandParser.java 57.14% <0.00%> (+57.14%) 3.00% <0.00%> (+3.00%)
...ivot/logic/parser/AddDescriptionCommandParser.java 72.72% <0.00%> (+72.72%) 3.00% <0.00%> (+3.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14ddd2...88f30ba. Read the comment docs.

Copy link

@constancensq constancensq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constancensq constancensq merged commit c22ed12 into AY2021S1-CS2103-F09-2:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3.2] Add Test Cases for all Previous Classes
3 participants