Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4.1] Change gender to sex, change email regex, change find to substring implementation #228

Merged

Conversation

constancensq
Copy link

No description provided.

@constancensq constancensq added the priority.High Must do label Nov 4, 2020
@constancensq constancensq self-assigned this Nov 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #228 into master will decrease coverage by 0.01%.
The diff coverage is 66.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #228      +/-   ##
============================================
- Coverage     59.81%   59.79%   -0.02%     
+ Complexity      740      732       -8     
============================================
  Files           140      140              
  Lines          2966     2980      +14     
  Branches        424      421       -3     
============================================
+ Hits           1774     1782       +8     
- Misses         1033     1036       +3     
- Partials        159      162       +3     
Impacted Files Coverage Δ Complexity Δ
...in/java/seedu/pivot/logic/commands/AddCommand.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../seedu/pivot/logic/commands/EditPersonCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/commands/suspectcommands/AddSuspectCommand.java 89.65% <ø> (ø) 9.00 <0.00> (ø)
...c/commands/suspectcommands/EditSuspectCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ogic/commands/victimcommands/AddVictimCommand.java 89.65% <ø> (ø) 9.00 <0.00> (ø)
...gic/commands/victimcommands/EditVictimCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ic/commands/witnesscommands/AddWitnessCommand.java 89.65% <ø> (ø) 9.00 <0.00> (ø)
...c/commands/witnesscommands/EditWitnessCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...u/pivot/logic/parser/EditSuspectCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...du/pivot/logic/parser/EditVictimCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f380e87...9e7bc7c. Read the comment docs.

@Vielheim Vielheim merged commit a99db4e into AY2021S1-CS2103-F09-2:master Nov 4, 2020
@constancensq constancensq added this to the v1.4 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Should provide non-binary gender options [PE-D] Strict Constraints for Find Function
3 participants