Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for editing person #235

Merged

Conversation

constancensq
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #235 into master will decrease coverage by 0.22%.
The diff coverage is 57.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
- Coverage     66.90%   66.68%   -0.23%     
- Complexity      841      851      +10     
============================================
  Files           143      143              
  Lines          3173     3212      +39     
  Branches        466      484      +18     
============================================
+ Hits           2123     2142      +19     
- Misses          835      841       +6     
- Partials        215      229      +14     
Impacted Files Coverage Δ Complexity Δ
...gic/commands/victimcommands/EditVictimCommand.java 83.33% <50.00%> (-4.77%) 12.00 <0.00> (ø)
...ot/model/investigationcase/caseperson/Suspect.java 76.47% <50.00%> (-23.53%) 10.00 <3.00> (+3.00) ⬇️
...vot/model/investigationcase/caseperson/Victim.java 76.47% <50.00%> (-23.53%) 10.00 <3.00> (+3.00) ⬇️
...ot/model/investigationcase/caseperson/Witness.java 76.47% <50.00%> (-23.53%) 10.00 <3.00> (+3.00) ⬇️
...c/commands/suspectcommands/EditSuspectCommand.java 83.33% <66.66%> (-4.77%) 12.00 <0.00> (ø)
...c/commands/witnesscommands/EditWitnessCommand.java 83.33% <66.66%> (-4.77%) 12.00 <0.00> (ø)
...ic/commands/suspectcommands/AddSuspectCommand.java 87.09% <100.00%> (ø) 9.00 <0.00> (ø)
...ogic/commands/victimcommands/AddVictimCommand.java 87.09% <100.00%> (ø) 9.00 <0.00> (ø)
...ic/commands/witnesscommands/AddWitnessCommand.java 87.09% <100.00%> (ø) 9.00 <0.00> (ø)
...ivot/model/investigationcase/caseperson/Email.java 83.33% <0.00%> (+8.33%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52cabab...76925f2. Read the comment docs.

Copy link

@CodyChew CodyChew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodyChew CodyChew merged commit 767fe1f into AY2021S1-CS2103-F09-2:master Nov 5, 2020
@constancensq constancensq added this to the v1.4 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants