Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Person to contain list of Suspects #78

Merged

Conversation

Vielheim
Copy link

@Vielheim Vielheim commented Oct 4, 2020

Add Suspect to Person class

@Vielheim Vielheim added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 4, 2020
@Vielheim Vielheim added this to the v1.2 milestone Oct 4, 2020
@Vielheim Vielheim self-assigned this Oct 4, 2020
@Vielheim Vielheim changed the title Add Suspect to Person class Update Person to contain list of Suspects Oct 4, 2020
Removed equal check for suspects
…nch-developer-Suspect

(Merge Constance's Victims into my Suspects)

* 'master' of github.com:AY2021S1-CS2103-F09-2/tp:
  Edit name variable in Victim to type Name
  Update Person to contain a list of victims

# Conflicts:
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/parser/AddCommandParser.java
#	src/main/java/seedu/address/model/person/Person.java
#	src/main/java/seedu/address/model/util/SampleDataUtil.java
#	src/main/java/seedu/address/storage/JsonAdaptedPerson.java
#	src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
#	src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java
#	src/test/java/seedu/address/testutil/PersonBuilder.java
1. Minor fixes to the code
Copy link

@constancensq constancensq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constancensq constancensq merged commit 4eaef49 into AY2021S1-CS2103-F09-2:master Oct 5, 2020
@Vielheim Vielheim linked an issue Oct 6, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.2.1] Add Suspect List Field to Case
2 participants