Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morph the addressbook into a library #112

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

Stefan-Jiang
Copy link

@Stefan-Jiang Stefan-Jiang commented Oct 21, 2020

Spotted errors in UI design and some tests commented out. Create a new intellibrary.log but still keep the original addressbook.log. Fixed #99

Copy link
Author

@Stefan-Jiang Stefan-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #112 into master will decrease coverage by 0.13%.
The diff coverage is 58.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
- Coverage     60.89%   60.76%   -0.14%     
  Complexity      475      475              
============================================
  Files            92       92              
  Lines          1785     1789       +4     
  Branches        236      236              
============================================
  Hits           1087     1087              
  Misses          630      630              
- Partials         68       72       +4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/commons/core/LogsCenter.java 76.31% <0.00%> (-2.07%) 10.00 <1.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 93.40% <ø> (ø) 12.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 33.33% <0.00%> (-66.67%) 2.00 <1.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 94.44% <ø> (ø) 15.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 17.64% <0.00%> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...seedu/address/storage/JsonSerializableLibrary.java 53.33% <50.00%> (ø) 2.00 <1.00> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f47793...9f1c74d. Read the comment docs.

@Stefan-Jiang Stefan-Jiang merged commit 5fe75cd into AY2021S1-CS2103-F09-3:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Morph AddressBook to IntelliBrary
2 participants