-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Morph the addressbook into a library #112
Morph the addressbook into a library #112
Conversation
…n comments or json files) / logging file not fixed / passed all the tests (spotted some tests commented out?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
============================================
- Coverage 60.89% 60.76% -0.14%
Complexity 475 475
============================================
Files 92 92
Lines 1785 1789 +4
Branches 236 236
============================================
Hits 1087 1087
Misses 630 630
- Partials 68 72 +4
Continue to review full report at Codecov.
|
Spotted errors in UI design and some tests commented out. Create a new intellibrary.log but still keep the original addressbook.log. Fixed #99