Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the edit review command #231

Merged

Conversation

HCY123902
Copy link

@HCY123902 HCY123902 commented Nov 2, 2020

Add the implementation of the edit review command.

Resolves #165
Resolves #166
Resolves #167
Resolves #168
Resolves #191
Resolves #192
Resolves #200
Resolves #206
Resolves #214

@HCY123902 HCY123902 added this to the v1.4 milestone Nov 2, 2020
@HCY123902 HCY123902 self-assigned this Nov 2, 2020
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #231 into master will decrease coverage by 1.31%.
The diff coverage is 1.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
- Coverage     46.57%   45.25%   -1.32%     
  Complexity      522      522              
============================================
  Files           126      128       +2     
  Lines          2508     2581      +73     
  Branches        329      336       +7     
============================================
  Hits           1168     1168              
- Misses         1255     1328      +73     
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 31.91% <0.00%> (-1.42%) 3.00 <0.00> (ø)
...seedu/address/logic/commands/AddReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...du/address/logic/commands/DeleteReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/EditReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/address/logic/commands/SearchReviewCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...u/address/logic/parser/AddReviewCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ddress/logic/parser/DeleteReviewCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../address/logic/parser/EditReviewCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/address/logic/parser/LibraryParser.java 47.05% <0.00%> (-1.43%) 12.00 <0.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0c2c...3819741. Read the comment docs.

@HCY123902 HCY123902 merged commit 63e6533 into AY2021S1-CS2103-F09-3:master Nov 2, 2020
Copy link

@richardcom richardcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new command of editing the review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment