Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update davidsqf.md #241

Merged

Conversation

davidsqf
Copy link

@davidsqf davidsqf commented Nov 3, 2020

fix #234

add a new line at EOF
@davidsqf davidsqf added documentation Improvements or additions to documentation type.Documentation priority.High labels Nov 3, 2020
@davidsqf davidsqf added this to the v1.4 milestone Nov 3, 2020
@davidsqf davidsqf self-assigned this Nov 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #241 into master will decrease coverage by 1.33%.
The diff coverage is 2.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
- Coverage     46.57%   45.23%   -1.34%     
  Complexity      522      522              
============================================
  Files           126      128       +2     
  Lines          2508     2582      +74     
  Branches        329      336       +7     
============================================
  Hits           1168     1168              
- Misses         1255     1329      +74     
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 31.91% <0.00%> (-1.42%) 3.00 <0.00> (ø)
...eedu/address/logic/commands/AddProblemCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/commands/AddReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...du/address/logic/commands/DeleteReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/EditReviewCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/address/logic/commands/SearchReviewCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...edu/address/logic/commands/ViewProblemCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../address/logic/parser/AddProblemCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...u/address/logic/parser/AddReviewCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2de9c0...9c5ab30. Read the comment docs.

@davidsqf davidsqf merged commit dabf490 into AY2021S1-CS2103-F09-3:master Nov 3, 2020
Copy link

@richardcom richardcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at the end of file LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.High type.Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update PPP of davidsqf
3 participants