Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test code for three models: Severity, Description, and Problem #242

Merged
merged 1 commit into from
Nov 3, 2020
Merged

add test code for three models: Severity, Description, and Problem #242

merged 1 commit into from
Nov 3, 2020

Conversation

davidsqf
Copy link

@davidsqf davidsqf commented Nov 3, 2020

fix #238

@davidsqf davidsqf added this to the v1.4 milestone Nov 3, 2020
@davidsqf davidsqf self-assigned this Nov 3, 2020
@davidsqf davidsqf merged commit f8fd564 into AY2021S1-CS2103-F09-3:master Nov 3, 2020
Stefan-Jiang
Stefan-Jiang reviewed Nov 3, 2020
View reviewed changes
Copy link

@Stefan-Jiang Stefan-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests added successfully increase the code coverage of the product and effectively reduce the risk of appearance of bugs. Good jobs! LGTM.

richardcom
richardcom reviewed Nov 3, 2020
View reviewed changes
Copy link

@richardcom richardcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test code LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Jiang Stefan-Jiang Stefan-Jiang left review comments

@richardcom richardcom richardcom left review comments

Assignees

@davidsqf davidsqf

Labels
priority.Medium type.Implementation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

add test code for models
3 participants
@davidsqf @Stefan-Jiang @richardcom