forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the review #244
Merged
davidsqf
merged 4 commits into
AY2021S1-CS2103-F09-3:master
from
HCY123902:branch-create-review
Nov 3, 2020
Merged
Update the review #244
davidsqf
merged 4 commits into
AY2021S1-CS2103-F09-3:master
from
HCY123902:branch-create-review
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsqf
reviewed
Nov 3, 2020
Comment on lines
+569
to
+653
* 1b1. The application shows that the stocking information of the book in some locations is not available. | ||
|
||
Use case ends. | ||
|
||
**Use case: UC06 - add the review for a book** | ||
|
||
**MSS** | ||
|
||
1. User requests to add a review record of a certain book. | ||
|
||
2. The application adds the review to the review list of the book, and shows the new review list. | ||
|
||
Use case ends. | ||
|
||
**Extensions** | ||
|
||
* 1a. The book specified by the user is not found in the current shown book list. | ||
|
||
* 1a1. The application shows an error message that the book specified is not valid. | ||
|
||
Use case ends. | ||
|
||
* 1b. The review given by the user has an invalid format, with the rating or review content missing or having incorrect format or value. | ||
|
||
* 1b1. The application shows an error message that the review given by the user is invalid and gives the suggestion on valid review. | ||
|
||
Use case ends. | ||
|
||
**Use case: UC07 - delete the review for a book** | ||
|
||
**MSS** | ||
|
||
1. User requests to delete a review record of a certain book. | ||
|
||
2. The application deletes the review to the review list of the book, and shows the updated review list. | ||
|
||
Use case ends. | ||
|
||
**Extensions** | ||
|
||
* 1a. The book specified by the user is not found in the current shown book list. | ||
|
||
* 1a1. The application shows an error message that the book specified is not valid. | ||
|
||
Use case ends. | ||
|
||
* 1b. The book review specified by the user is not found in the review list of the book. | ||
|
||
* 1a1. The application shows an error message that the review specified is not valid. | ||
|
||
Use case ends. | ||
|
||
**Use case: UC08 - edit the review for a book** | ||
|
||
**MSS** | ||
|
||
1. User requests to edit a review record of a certain book. | ||
|
||
2. The application edits the review to the review list of the book, and shows the updated review list. | ||
|
||
Use case ends. | ||
|
||
**Extensions** | ||
|
||
* 1a. The book specified by the user is not found in the current shown book list. | ||
|
||
* 1a1. The application shows an error message that the book specified is not valid. | ||
|
||
Use case ends. | ||
|
||
* 1b. The book review specified by the user is not found in the review list of the book. | ||
|
||
* 1a1. The application shows an error message that the review specified is not valid. | ||
|
||
Use case ends. | ||
|
||
* 1c. The new review given by the user has an invalid format, with the rating or review content missing or having incorrect format or value. | ||
|
||
* 1c1. The application shows an error message that the review given by the user is invalid and gives the suggestion on valid review. | ||
|
||
Use case ends. | ||
|
||
* 1c. The new review given by the user is equivalent to the original review. | ||
|
||
* 1c1. The application shows an error message that the review given by the user does not make changes to the original review and the value of the edited review needs to be different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
richardcom
reviewed
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of the reivew LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the review command, use case, and documentation.
Resolves #243