Add times command to the project #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM |
HCY123902
reviewed
Nov 3, 2020
| import seedu.address.model.Model; | ||
| import seedu.address.model.person.Person; | ||
| import seedu.address.model.person.Times; | ||
|
|
There was a problem hiding this comment.
LGTM. The concept of polymorphism and the command pattern seems to be present.
HCY123902
reviewed
Nov 3, 2020
| @@ -5,42 +5,49 @@ | |||
| "phone" : "94351253", | |||
| "email" : "alice@example.com", | |||
| "address" : "123, Jurong West Ave 6, #08-111", | |||
| "times": "", | |||
There was a problem hiding this comment.
Maybe some real time numbers can be added instead of giving an empty value.
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TimesTest { | ||
|
|
There was a problem hiding this comment.
There can also be some check about the valid time number string.
| */ | ||
| public Times(String times) { | ||
| requireNonNull(times); | ||
| value = times; |
There was a problem hiding this comment.
Maybe there can also be an upper bound for the number of times that a book can be borrowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and integrate a new attribute TIMES into the system.
Fixed #72 #73