Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caiyi34777 category implementation update #83

Conversation

Caiyi34777
Copy link

fix #70

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@82ab5b1). Click here to learn what that means.
The diff coverage is 84.97%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   73.02%           
  Complexity        ?      429           
=========================================
  Files             ?       74           
  Lines             ?     1327           
  Branches          ?      137           
=========================================
  Hits              ?      969           
  Misses            ?      320           
  Partials          ?       38           
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (?)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/address/model/util/SampleDataUtil.java 25.00% <25.00%> (ø) 2.00 <1.00> (?)
...c/main/java/seedu/address/model/person/Author.java 70.00% <70.00%> (ø) 5.00 <5.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 85.36% <75.00%> (ø) 14.00 <6.00> (?)
...in/java/seedu/address/model/category/Category.java 80.00% <80.00%> (ø) 5.00 <5.00> (?)
.../java/seedu/address/storage/JsonAdaptedPerson.java 91.93% <87.17%> (ø) 12.00 <12.00> (?)
...rc/main/java/seedu/address/model/person/Times.java 87.50% <87.50%> (ø) 6.00 <6.00> (?)
.../seedu/address/logic/parser/EditCommandParser.java 92.85% <90.00%> (ø) 11.00 <4.00> (?)
...c/main/java/seedu/address/model/person/Person.java 95.91% <91.30%> (ø) 23.00 <5.00> (?)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ab5b1...0913888. Read the comment docs.

@Caiyi34777 Caiyi34777 merged commit 3381f34 into AY2021S1-CS2103-F09-3:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement attribute Category(from tag)
2 participants