Implement deleteBy ISBN or times and add tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
HCY123902
reviewed
Nov 6, 2020
| @@ -24,11 +24,18 @@ | |||
| public static final String MESSAGE_DELETE_BOOK_SUCCESS = "Deleted Book: %1$s"; | |||
|
|
|||
| private final String targetName; | |||
| private final int attribute; | |||
| /** | ||
| * Parses input arguments and creates a new DeleteByCommand object | ||
| */ | ||
| public class DeleteByCommandParser implements Parser<DeleteByCommand> { |
There was a problem hiding this comment.
LGTM. Interesting command with the usage of different types of keyword. Maybe there can also be the functionality to delete using more than 1 keyword at the same time.
|
|
||
| import seedu.address.logic.commands.DeleteByCommand; | ||
|
|
||
|
|
HCY123902
reviewed
Nov 8, 2020
| boolean isTimesPresent = isPrefixesPresent(argMultimap, PREFIX_TIMES) | ||
| && !arePrefixesPresent(argMultimap, PREFIX_NAME, PREFIX_ISBN); | ||
|
|
||
|
|
There was a problem hiding this comment.
LGTM. The defensiveness seems to be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement deleteBy ISBN or times and add tests
Fix #52