Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted bugfixes #164

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Conversation

youyingfeng
Copy link

No description provided.

@youyingfeng youyingfeng added this to the v1.4 milestone Nov 4, 2020
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #164 into master will increase coverage by 2.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
+ Coverage     43.85%   46.37%   +2.51%     
- Complexity      447      470      +23     
============================================
  Files           120      120              
  Lines          2353     2357       +4     
  Branches        259      259              
============================================
+ Hits           1032     1093      +61     
+ Misses         1254     1197      -57     
  Partials         67       67              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/person/Name.java 80.00% <100.00%> (ø) 8.00 <3.00> (+2.00)
...rc/main/java/seedu/address/model/person/Order.java 38.29% <100.00%> (+8.06%) 6.00 <1.00> (+2.00)
...rc/main/java/seedu/address/model/ModelManager.java 79.72% <0.00%> (+4.05%) 29.00% <0.00%> (+2.00%)
...va/seedu/address/model/person/UniqueOrderList.java 43.90% <0.00%> (+4.87%) 10.00% <0.00%> (+1.00%)
src/main/java/seedu/address/model/AddressBook.java 69.62% <0.00%> (+5.06%) 22.00% <0.00%> (+2.00%)
...in/java/seedu/address/logic/parser/ParserUtil.java 86.00% <0.00%> (+6.00%) 17.00% <0.00%> (+1.00%)
...du/address/logic/commands/DeleteClientCommand.java 100.00% <0.00%> (+47.82%) 10.00% <0.00%> (+3.00%)
...model/person/OrderIdContainsKeywordsPredicate.java 71.42% <0.00%> (+71.42%) 2.00% <0.00%> (+2.00%)
...edu/address/logic/commands/DeleteOrderCommand.java 100.00% <0.00%> (+73.91%) 10.00% <0.00%> (+4.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ebf7b...788785a. Read the comment docs.

@youyingfeng youyingfeng linked an issue Nov 4, 2020 that may be closed by this pull request
@youyingfeng youyingfeng linked an issue Nov 4, 2020 that may be closed by this pull request
@youyingfeng youyingfeng merged commit cb9e80b into AY2021S1-CS2103-F09-4:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment